Skip to content

[WIP] Convert CVSSv2 into CVSSv3 - #1204

Closed
ziadhany wants to merge 2 commits into
aboutcode-org:mainfrom
ziadhany:convert_cvssv2_to_cvssv3
Closed

[WIP] Convert CVSSv2 into CVSSv3#1204
ziadhany wants to merge 2 commits into
aboutcode-org:mainfrom
ziadhany:convert_cvssv2_to_cvssv3

Conversation

@ziadhany

Copy link
Copy Markdown
Collaborator

issue : #1187

@ziadhany
ziadhany marked this pull request as ready for review May 30, 2023 11:56
@ziadhany

ziadhany commented May 30, 2023

Copy link
Copy Markdown
Collaborator Author

according to my assumption, I tried to find the best way of doing this.
but I am not sure about how accurate the result

Take a look at the result : output.txt

@ziadhany
ziadhany force-pushed the convert_cvssv2_to_cvssv3 branch from cf79d80 to a142854 Compare June 6, 2023 15:37
Comment thread vulnerabilities/severity_systems.py Outdated
@ziadhany
ziadhany force-pushed the convert_cvssv2_to_cvssv3 branch 2 times, most recently from 02e8616 to 9de5457 Compare July 11, 2023 10:51
Test function with nvd_cvss.csv data
Remove function from severity_systems.py
Rename file to cvss2to3.py
Add download_url fof severity_systems.py.ABOUT
Fix notes
Test with nvd severity data
Move the cvssv2_converter.py to serverity_systems.py
Give credit to Marc Ruef
Fix missing parts in the vector
Add some tests
Edit CI,  II , AI to C , I,  A
Convert CVSSv2 into CVSSv3

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
ziadhany force-pushed the convert_cvssv2_to_cvssv3 branch from 9de5457 to b0cb62b Compare July 25, 2023 13:17
@ziadhany

Copy link
Copy Markdown
Collaborator Author

Test result :

Screenshot from 2023-07-25 16-11-46

@pombredanne

Copy link
Copy Markdown
Member

@ziadhany re: #1204 (comment)
Does this mean that mosts v2 to v3 tests are failing ... compared to the NVD?

@ziadhany

ziadhany commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator Author

@ziadhany re: #1204 (comment) Does this mean that mosts v2 to v3 tests are failing ... compared to the NVD?

I tried to improve it , the test result was less 10% but after some debugging we got 36.4315898% with a small problems with Base Score Metrics

@TG1999
TG1999 marked this pull request as draft December 12, 2023 17:15
@TG1999 TG1999 changed the title Convert CVSSv2 into CVSSv3 [WIP] Convert CVSSv2 into CVSSv3 Dec 12, 2023
@ziadhany
ziadhany marked this pull request as ready for review July 2, 2024 16:07
@TG1999
TG1999 marked this pull request as draft July 9, 2024 15:42
@TG1999

TG1999 commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

@ziadhany @pombredanne what shall be done for this PR ?

@ziadhany ziadhany closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants